Skip to content

Update huawei-lte-api to 1.4.3#27269

Closed
chmielowiec wants to merge 1 commit into
home-assistant:devfrom
chmielowiec:dev
Closed

Update huawei-lte-api to 1.4.3#27269
chmielowiec wants to merge 1 commit into
home-assistant:devfrom
chmielowiec:dev

Conversation

@chmielowiec
Copy link
Copy Markdown
Contributor

@chmielowiec chmielowiec commented Oct 6, 2019

Description:

Update huawei-lte-api to latest version

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@chmielowiec chmielowiec requested a review from scop as a code owner October 6, 2019 21:30
@probot-home-assistant probot-home-assistant Bot added Hacktoberfest dependency Pull requests marked as a dependency upgrade integration: huawei_lte small-pr PRs with less than 30 lines. labels Oct 6, 2019
@scop
Copy link
Copy Markdown
Member

scop commented Oct 7, 2019

Thanks, but there should be no need to do this right now, as there are no changes that would affect the behavior with the current code except for some cosmetics, and the changes between 1.4.2 and 1.4.3 are very lightly, if at all tested by upstream or anyone else. Stuff in #26675 will on the other hand require the upgrade, I will do this as part of that.

If I missed something, let me know.

@scop scop closed this Oct 7, 2019
@scop scop removed the invalid label Oct 7, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed dependency Pull requests marked as a dependency upgrade integration: huawei_lte small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants