Skip to content

Fix onvif PTZ service freeze#27250

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
skgsergio:fix-onvif-ptz
Oct 6, 2019
Merged

Fix onvif PTZ service freeze#27250
MartinHjelmare merged 1 commit into
home-assistant:devfrom
skgsergio:fix-onvif-ptz

Conversation

@skgsergio
Copy link
Copy Markdown
Contributor

Description:

Using onvif service camera.onvif_ptz freezes HA. This is due a call to a non-async function extract_entity_ids inside an async service handler.

The fix is pretty easy and is just calling async_extract_entity_ids instead.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@skgsergio skgsergio changed the title Fix onvif PTZ freeze Fix onvif PTZ service freeze Oct 6, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 6cc71db into home-assistant:dev Oct 6, 2019
@MartinHjelmare MartinHjelmare added this to the 0.100 milestone Oct 6, 2019
@balloob balloob removed the invalid label Oct 6, 2019
@skgsergio skgsergio deleted the fix-onvif-ptz branch October 6, 2019 15:29
@lock lock Bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants