Skip to content

Updates hotwater to be hot_water #27032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KJonline wants to merge 36 commits into from
Closed

Updates hotwater to be hot_water #27032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
3da4e2a
Start the Boost work
Sep 4, 2019
40546d0
Add services.yaml
Sep 4, 2019
55f1c07
Added Services #2
Sep 8, 2019
9ecbc49
Start the Boost work
Sep 4, 2019
a6ec9df
Add services.yaml
Sep 4, 2019
8d1d373
Added Services #2
Sep 8, 2019
4a0433a
Merge branch 'feature/add_boost' of github.com:KJonline/home-assistan…
Sep 8, 2019
a1eb496
Working Services
Sep 8, 2019
917d290
Merge branch 'dev' into feature/add_boost
Sep 11, 2019
2f37b6c
pyhiveapi to 0.2.19
Rendili Sep 12, 2019
43199ff
Update Libary to 0.2.19
Sep 14, 2019
2fddd8c
Merge branch 'feature/add_boost' of github.com:KJonline/home-assistan…
Sep 15, 2019
5b37b27
Merge branch 'dev' into feature/add_boost
Sep 15, 2019
6488112
Update Water_heater boost
Rendili Sep 17, 2019
17f0e26
Added Async hass add function
Sep 20, 2019
9576209
Update Services
Sep 21, 2019
ca26b29
Merge branch 'dev' into feature/add_boost
Sep 21, 2019
3c37392
MERGED
Sep 21, 2019
6faac31
Reviewed Changes
Sep 22, 2019
b7c5d85
Fixed Refresh System
Sep 22, 2019
aad3aad
Review 2
Sep 22, 2019
d4db766
Moved device iteration to the platform
Sep 23, 2019
aa92c41
update
Sep 23, 2019
adcd69c
Updates #2
Sep 24, 2019
4922ae4
Review#3 New Base Class
Sep 24, 2019
f2eb368
Review #5
Sep 26, 2019
b3d91a2
Merge branch 'dev' into feature/add_boost
Sep 26, 2019
36b8516
Update homeassistant/components/hive/__init__.py
Sep 26, 2019
c95027a
Update homeassistant/components/hive/__init__.py
Sep 26, 2019
5084044
Update homeassistant/components/hive/__init__.py
Sep 26, 2019
73da60c
Review 6
Sep 26, 2019
7276045
Review 7
Sep 26, 2019
1ed828e
Removed Child classes to inhertit from the parent
Sep 27, 2019
f27e6f8
Update Service to Hot_Water
Sep 28, 2019
fdde87c
Updated Requirements
Sep 28, 2019
1047248
Merge branch 'dev' into feature/add_boost
Sep 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions homeassistant/components/hive/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
DOMAIN = "hive"
DATA_HIVE = "data_hive"
SERVICES = ["Heating", "HotWater"]
SERVICE_BOOST_HOTWATER = "boost_hotwater"
SERVICE_BOOST_HOT_WATER = "boost_hot_water"
SERVICE_BOOST_HEATING = "boost_heating"
ATTR_TIME_PERIOD = "time_period"
ATTR_MODE = "on_off"
Expand Down Expand Up @@ -59,7 +59,7 @@
}
)

BOOST_HOTWATER_SCHEMA = vol.Schema(
BOOST_HOT_WATER_SCHEMA = vol.Schema(
{
vol.Required(ATTR_ENTITY_ID): cv.entity_id,
vol.Optional(ATTR_TIME_PERIOD, default="00:30:00"): vol.All(
Expand Down Expand Up @@ -100,7 +100,7 @@ def heating_boost(service):

session.heating.turn_boost_on(node_id, minutes, temperature)

def hotwater_boost(service):
def hot_water_boost(service):
"""Handle the service call."""
node_id = HiveSession.entity_lookup.get(service.data[ATTR_ENTITY_ID])
if not node_id:
Expand Down Expand Up @@ -151,9 +151,9 @@ def hotwater_boost(service):
if ha_type == "water_heater":
hass.services.register(
DOMAIN,
SERVICE_BOOST_HEATING,
hotwater_boost,
schema=BOOST_HOTWATER_SCHEMA,
SERVICE_BOOST_HOT_WATER,
hot_water_boost,
schema=BOOST_HOT_WATER_SCHEMA,
)

return True
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/hive/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "Hive",
"documentation": "https://www.home-assistant.io/components/hive",
"requirements": [
"pyhiveapi==0.2.19"
"pyhiveapi==0.2.19.1"
],
"dependencies": [],
"codeowners": [
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/hive/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ boost_heating:
description: Set the target temperature for the boost period.,
example: "20.5",
}
boost_hotwater:
boost_hot_water:
description:
"Set the boost mode ON or OFF defining the period of time for the boost."
fields:
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@ pyheos==0.6.0
pyhik==0.2.3

# homeassistant.components.hive
pyhiveapi==0.2.19
pyhiveapi==0.2.19.1

# homeassistant.components.homematic
pyhomematic==0.1.60
Expand Down