Skip to content

Add myself as a pi_hole codeowner#26796

Merged
frenck merged 1 commit into
home-assistant:devfrom
johnluetke:patch-1
Sep 21, 2019
Merged

Add myself as a pi_hole codeowner#26796
frenck merged 1 commit into
home-assistant:devfrom
johnluetke:patch-1

Conversation

@johnluetke
Copy link
Copy Markdown
Contributor

Description:

I significantly refactored the pi-hole integration, so per ADR-008, I'm adding myself as a code owner.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @johnluetke! 👍 ❤️

@frenck frenck merged commit 88dceca into home-assistant:dev Sep 21, 2019
@johnluetke johnluetke deleted the patch-1 branch September 21, 2019 20:16
@lock lock Bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants