Skip to content

Fix doods missing detector name kwarg#26784

Merged
cgarwood merged 3 commits into
home-assistant:devfrom
snowzach:pydoods_fix
Sep 21, 2019
Merged

Fix doods missing detector name kwarg#26784
cgarwood merged 3 commits into
home-assistant:devfrom
snowzach:pydoods_fix

Conversation

@snowzach
Copy link
Copy Markdown
Contributor

Breaking Change:

No breaking changes

Description:

The new doods component is missing an option to select the detector being used. In its current form it will only use the default detector and ignores the detector config option.

No documentation or configuration changes are required. The documentation is already correct.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • [ X] Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare changed the title Doods component - fix missing detector name kwarg Fix doods missing detector name kwarg Sep 21, 2019
@cgarwood cgarwood merged commit 9e79920 into home-assistant:dev Sep 21, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants