Add Ombi integration

[larssont]

Description:

Integration for Ombi sensors and services.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10400

Example entry for configuration.yaml (if applicable):

ombi:
  api_key: b5y5cxs3g8a6mskpmegdfdvvfc3o2wp4
  host: 192.168.1.120
  username: myusername42

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

[MartinHjelmare]

Code looks great!

Is there a chance that more platforms will be created for this integration, eg media_player, or custom services? In that case we should consider moving the config section to under the integration key and set up the sensor platform via discovery from the component module.

[larssont]

@MartinHjelmare
Alright, I looked over the API and did some tests and I think implementing some custom services would definitely be possible. Since Ombi's main purpose is to request movies and TV Shows and also approve requests, it would be feasible to implement a custom service that for instance searched and subsequently requested something on Ombi through the component. Although, I would have to update the pyombi package before implementing any of that here obviously.

[MartinHjelmare]

I would recommend putting the config under the integration domain key instead and refactor to use helpers.discovery.load_platform to load the platform from the component module.

https://github.com/home-assistant/home-assistant/blob/54242cd65c1d69d88ec366f545313cf003e9cbbb/homeassistant/helpers/discovery.py#L110
We need to define a CONFIG_SCHEMA in the component and remove the PLATFORM_SCHEMA in the platform.

The ombi api instance should be created in the component and stored in hass.data, to later be accessible from the platform.

[tidusjar]

Nice!

[larssont]

I think everything should be included now. I separated the config from the sensor setup and added a couple of service calls for different types of requests. I've added in music support as well just for the sake of it. The only thing I'm a bit indecisive about is if I should implement some type of response on how each service request was handled, i.e. whether they succeeded or not. Let me know if you have any ideas for this.

[MartinHjelmare]

We can raise an error in the service handler on failure. This will be shown to the user.

[MartinHjelmare]

Looks great!

[MartinHjelmare]

Please update the config example in the PR description.

[larssont]

Great! Thanks for all the feedback, I'll make sure to update the docs.

[MartinHjelmare]

Ping me when the yaml example above is updated and I'll merge here.

[larssont]

@MartinHjelmare Fixed!