Update Vivotek camera component#26754
Merged
MartinHjelmare merged 3 commits intoSep 22, 2019
Merged
Conversation
Load model name to instance attribute
probot-home-assistant
Bot
added
integration: vivotek
small-pr
MartinHjelmare
requested changes
Sep 20, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Call add_entities with second argument True to make sure update is called during entity addition.
add_entities(entities, True)Ensure `update` is called when the entity is added.
https://pypi.org/project/libpyvivotek/0.2.2/ - Retrieve camera model name anonymously - Raise a more helpful error for invalid creds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load model name to instance attribute
Description:
Related issue (if applicable): fixes #26607
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.