Skip to content

Add alternative name for Tibber sensors#26685

Merged
Danielhiversen merged 2 commits into
devfrom
tibber
Sep 18, 2019
Merged

Add alternative name for Tibber sensors#26685
Danielhiversen merged 2 commits into
devfrom
tibber

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Description:

Add alternative name for Tibber sensors

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Comment thread homeassistant/components/tibber/sensor.py Outdated
Comment thread homeassistant/components/tibber/sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Danielhiversen Danielhiversen merged commit 72baf56 into dev Sep 18, 2019
@Danielhiversen Danielhiversen deleted the tibber branch September 18, 2019 05:31
@lock lock Bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants