Skip to content

deCONZ rewrite sensor tests#26679

Merged
balloob merged 5 commits into
home-assistant:devfrom
Kane610:deconz-fix-sensor-tests
Sep 18, 2019
Merged

deCONZ rewrite sensor tests#26679
balloob merged 5 commits into
home-assistant:devfrom
Kane610:deconz-fix-sensor-tests

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Sep 16, 2019

Description:

Improve deconz sensor tests

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Kane610 Kane610 self-assigned this Sep 16, 2019
@probot-home-assistant probot-home-assistant Bot added has-tests small-pr PRs with less than 30 lines. labels Sep 16, 2019
@Kane610 Kane610 changed the title deCONZ fix sensor tests deCONZ rewrite sensor tests Sep 17, 2019
@Kane610 Kane610 changed the title deCONZ rewrite sensor tests WIP: deCONZ rewrite sensor tests Sep 18, 2019
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Sep 18, 2019

I've identified a few things to improve before this PR is ready

Fixed!

@Kane610 Kane610 force-pushed the deconz-fix-sensor-tests branch from 939a706 to 20631dd Compare September 18, 2019 15:11
@Kane610 Kane610 changed the title WIP: deCONZ rewrite sensor tests deCONZ rewrite sensor tests Sep 18, 2019
@balloob balloob merged commit 886d8bd into home-assistant:dev Sep 18, 2019
@Kane610 Kane610 deleted the deconz-fix-sensor-tests branch September 18, 2019 17:30
@lock lock Bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants