Skip to content

Add Kaiterra integration#26661

Merged
MartinHjelmare merged 9 commits into
home-assistant:devfrom
Michsior14:feature/kaiterra-integration
Sep 22, 2019
Merged

Add Kaiterra integration#26661
MartinHjelmare merged 9 commits into
home-assistant:devfrom
Michsior14:feature/kaiterra-integration

Conversation

@Michsior14
Copy link
Copy Markdown
Contributor

@Michsior14 Michsior14 commented Sep 15, 2019

Description:

Support for Laser Egg and Sansedge devices.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10374

Example entry for configuration.yaml (if applicable):

kaiterra:
  api_key: YOUR_API_KEY
  devices:
    - device_id: YOUR_DEVICE_ID
      type: YOUR_DEVICE_TYP

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @Michsior14,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Comment thread homeassistant/components/kaiterra/sensor.py Outdated
@MartinHjelmare MartinHjelmare changed the title add Kaiterra integration Add Kaiterra integration Sep 15, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mostly just need to tidy up dict access.

Comment thread homeassistant/components/kaiterra/__init__.py Outdated
Comment thread homeassistant/components/kaiterra/__init__.py Outdated
Comment thread homeassistant/components/kaiterra/__init__.py Outdated
Comment thread homeassistant/components/kaiterra/__init__.py Outdated
Comment thread homeassistant/components/kaiterra/__init__.py Outdated
Comment thread homeassistant/components/kaiterra/sensor.py Outdated
Comment thread homeassistant/components/kaiterra/sensor.py Outdated
Comment thread homeassistant/components/kaiterra/sensor.py Outdated
Comment thread homeassistant/components/kaiterra/sensor.py Outdated
Comment thread homeassistant/components/kaiterra/sensor.py Outdated
Michsior14 and others added 2 commits September 21, 2019 21:02
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Comment thread homeassistant/components/kaiterra/sensor.py Outdated
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit fbe85a2 into home-assistant:dev Sep 22, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants