Fix cert expiry config flow check and update

[cereal2nd]

Description:

Related issue (if applicable): fixes #26619

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

[MartinHjelmare]

Can we fix the call to get_cert in the config flow in this PR too?

[cereal2nd]

Can we fix the call to get_cert in the config flow in this PR too?

would be good, but i have no clue how to do it ...

[MartinHjelmare]

Here:
https://github.com/home-assistant/home-assistant/blob/41c9ed5d5133fe19515959b890f8c748bff0bfb8/homeassistant/components/cert_expiry/config_flow.py#L41-L52

Do this:

async def _test_connection(self, user_input):
    """Test connection to the server and try to get the certificate."""
    try:
        await self.hass.async_add_executor_job(
            get_cert, user_input[CONF_HOST], user_input.get(CONF_PORT, DEFAULT_PORT))
        return True
    except socket.gaierror:
        self._errors[CONF_HOST] = "resolve_failed"
    except socket.timeout:
        self._errors[CONF_HOST] = "connection_timeout"
    except OSError:
        self._errors[CONF_HOST] = "certificate_fetch_failed"
    return False

And here:
https://github.com/home-assistant/home-assistant/blob/41c9ed5d5133fe19515959b890f8c748bff0bfb8/homeassistant/components/cert_expiry/config_flow.py#L62

Do this:

if await self._test_connection(user_input):

[cereal2nd]

i was trying something like that but it did not work ...

  File "/home/cereal/home-assistant/homeassistant/components/cert_expiry/config_flow.py", line 64, in async_step_user
    if await self._test_connection(user_input):
  File "/home/cereal/home-assistant/homeassistant/components/cert_expiry/config_flow.py", line 45, in _test_connection
    get_cert(user_input[CONF_HOST], user_input.get(CONF_PORT, DEFAULT_PORT))
  File "/usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
TypeError: 'dict' object is not callable

[MartinHjelmare]

We can't call get_cert before we send it to the executor via hass.async_add_executor_job. We should just pass the function and it's arguments.

await self.hass.async_add_executor_job(get_cert, arg1, arg2)

[cereal2nd]

Thanks i really have some learning todo with the async io system ....

All items are solved now, so lets hope we can get it fixed before 0.99 is released

[MartinHjelmare]

Thanks!

[luca-angemi]

Hi guys, not sure if this is the right place to comment but I've applied these changes to the code and the behaviour is still the same: no sensor gets created using yaml and I get a timeout error using config flow.

[MartinHjelmare]

Can you test the site/certificate separately?

[cereal2nd]

can you try with the same python as hass is running the next code?

import socket address = (<host>, <port>) socket.create_connection(address, timeout=10)

and see what it returns?

[cereal2nd]

@MartinHjelmare what would be the problem with the CI for python 2.6?

https://dev.azure.com/home-assistant/Home%20Assistant/_build/results?buildId=8940&view=logs&j=641e29f4-92ec-5dde-69c3-b45a7bd26967&t=a889306f-ddd6-5fc9-6488-5f3f5770f1cb&l=194

[luca-angemi]

Sure

[pvizeli]

Test fails because of wrong handling with asyncio