Skip to content

Update radiotherm climate attributes#26465

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
dieselrabbit:radiotherm-lovelace
Sep 6, 2019
Merged

Update radiotherm climate attributes#26465
MartinHjelmare merged 2 commits into
home-assistant:devfrom
dieselrabbit:radiotherm-lovelace

Conversation

@dieselrabbit
Copy link
Copy Markdown
Contributor

@dieselrabbit dieselrabbit commented Sep 6, 2019 •
edited by MartinHjelmare
Loading

Breaking Change:

  • The old "mode" attribute is now supported via "hvac_action" attribute.
  • The old "fan" attribute now called "fan_action" to follow "hvac_action" .
  • Automations may break if the user is checking against the previous "mode" or "fan" attributes or previous mode or fan attribute values.

Description:

  • Adds hvac_action property to better support the Lovelace Climate card. Now uses common current_hvac constants.
  • Clean up "fan" attribute. Now called "fan_action", as "mode" is supported via hvac_action. Now uses common fan-specific constants.
  • Update current operation label from "Off" to "Idle".

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@dieselrabbit
Update radiotherm for lovelace
11e4435 
-Adds hvac_action property to better support the Lovelace Climate card.
-Clean up "fan" attribute. Now called "fan_action", as "mode" is supported via hvac_action.
-Update current operation label from "Off" to "Idle".
@probot-home-assistant probot-home-assistant Bot added integration: radiotherm small-pr PRs with less than 30 lines. labels Sep 6, 2019
MartinHjelmare
MartinHjelmare approved these changes Sep 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare changed the title Update radiotherm for lovelace Update radiotherm climate attributes Sep 6, 2019
@MartinHjelmare MartinHjelmare merged commit f9445c9 into home-assistant:dev Sep 6, 2019
@dieselrabbit dieselrabbit deleted the radiotherm-lovelace branch September 7, 2019 06:12
@lock lock Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

breaking-change cla-signed integration: radiotherm small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dieselrabbit @MartinHjelmare @homeassistant