Fix spaceapi#26453
Conversation
| cv.ensure_list, [vol.In(ISSUE_REPORT_CHANNELS)] | ||
| ), | ||
| vol.Required(CONF_LOCATION): LOCATION_SCHEMA, | ||
| vol.Optional(CONF_LOCATION): LOCATION_SCHEMA, |
There was a problem hiding this comment.
I made the address a requirement in the first place because for most humans it's faster to work with the actual address than coordinates even if it's not a requirement by the SpaceAPI. But in regard of that those information are not consumed by humans it's the right choose to follow the SpaceAPI requirements.
This change makes it a Breaking change.
There was a problem hiding this comment.
Does a Breaking Change need any special actions to take place?
There was a problem hiding this comment.
Beside the Breaking Change: section in the PR template which should describe the changes and the migration path for the users, no.
There was a problem hiding this comment.
OK, will do that tomorrow!
There was a problem hiding this comment.
@fabaff I've thought a little about this one and in my opinion its not a breaking change. It's just optional now. All user have the location set at the moment as it was required until now and works without the need to change anything.
| vol.Optional(CONF_EMAIL): cv.string, | ||
| vol.Optional(CONF_IRC): cv.string, | ||
| vol.Optional(CONF_MAILING_LIST): cv.string, | ||
| vol.Optional(CONF_ML): cv.string, |
There was a problem hiding this comment.
This change makes it a Breaking change.
There was a problem hiding this comment.
Again, does a Breaking Change need any special actions to take place?
There was a problem hiding this comment.
I've described the breaking change and the steps to migrate in the PR template as requested.
|
@fabaff Is there anything left for me to do or is it just waiting for the PR to be merged? |
|
CI is not passing. |
Co-Authored-By: Fabian Affolter <mail@fabian-affolter.ch>
Co-Authored-By: Fabian Affolter <mail@fabian-affolter.ch>
🤦♂ It was so obvious and I didn't realize what the problem was. |
3 participants
Breaking Change:
Values that were not complient with the SpaceAPI specification an therefore were changed.
contact / mailing_listwere changed tocontact / ml, to migrate change themailing_listkey tomllocation / addressis no longer required but optional (the lat/lon properties of location are added automatically from the HA config). No need to change something.Description:
Some values were not compliant to the specification others were not validated at all.
Now almost all values are supported, not supported are:
eventsI've no idea how over time changing events should be integrated. Maybe some has an idea how to do that.contact/google/plusAs Google+ is discontinued, I've not implemented this value.state/trigger_personAgain, no idea how to sove this.state/trigger_personSame as trigger_person.Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10296
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: