Skip to content

Change darksky icon for clear night#26452

Merged
fabaff merged 2 commits into
home-assistant:devfrom
Mariusthvdb:patch-1
Sep 6, 2019
Merged

Change darksky icon for clear night#26452
fabaff merged 2 commits into
home-assistant:devfrom
Mariusthvdb:patch-1

Conversation

@Mariusthvdb
Copy link
Copy Markdown
Contributor

@Mariusthvdb Mariusthvdb commented Sep 5, 2019

change mdi:weather-sunny to mdi:weather-night for condition clear night

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

change mdi:weather-sunny to mdi:night for condition clear night
@Mariusthvdb Mariusthvdb requested a review from fabaff as a code owner September 5, 2019 12:26
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @Mariusthvdb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

Mariusthvdb commented Sep 5, 2019

seems silly awkward to show a bright shining sun during the night..

@MartinHjelmare MartinHjelmare changed the title change icon for clear night Change darsky icon for clear night Sep 5, 2019
@MartinHjelmare MartinHjelmare changed the title Change darsky icon for clear night Change darksky icon for clear night Sep 5, 2019
Comment thread homeassistant/components/darksky/sensor.py Outdated
@fabaff fabaff merged commit 50cec91 into home-assistant:dev Sep 6, 2019
@Mariusthvdb Mariusthvdb deleted the patch-1 branch September 6, 2019 09:46
@lock lock Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants