Skip to content

Expose current direction properly on state machine#26298

Merged
balloob merged 2 commits into
devfrom
fix-direction
Sep 2, 2019
Merged

Expose current direction properly on state machine#26298
balloob merged 2 commits into
devfrom
fix-direction

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Aug 30, 2019

Description:

There was a bug in prop_to_attr mapping, causing fan entity to expose self.direction instead of self.current_direction to the state machine. This was also incorrectly implemented in the demo.

I thought about just changing it all to self.direction, but that would be a breaking change, and now it is like documented 👍

This fixes it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.98.2 milestone Aug 31, 2019
@andrewsayre
Copy link
Copy Markdown
Member

andrewsayre commented Aug 31, 2019

It looks like this line would need to change to use current_direction? Weird it passedin python 3.7?

Edit: So not the test that's the issue, but the fan platform of template is defining self.direction instead of self.current_direction. I've scanned the code base and this was the only other instance I found.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Aug 31, 2019

it didn't pass in 3.7 but there is something else odd going on there. Opened #26311 to track it.

@balloob balloob merged commit aa7513b into dev Sep 2, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix-direction branch September 2, 2019 04:43
balloob added a commit that referenced this pull request Sep 2, 2019
* Expose current direction properly on state machine

* Fix template fan
@balloob balloob mentioned this pull request Sep 2, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants