Expose current direction properly on state machine#26298
Merged
Conversation
Member
|
It looks like this line would need to change to use Edit: So not the test that's the issue, but the fan platform of template is defining |
Member
Author
|
it didn't pass in 3.7 but there is something else odd going on there. Opened #26311 to track it. |
MartinHjelmare
approved these changes
Aug 31, 2019
balloob
added a commit
that referenced
this pull request
Sep 2, 2019
* Expose current direction properly on state machine * Fix template fan
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There was a bug in prop_to_attr mapping, causing fan entity to expose
self.directioninstead ofself.current_directionto the state machine. This was also incorrectly implemented in the demo.I thought about just changing it all to
self.direction, but that would be a breaking change, and now it is like documented 👍This fixes it.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: