Skip to content

Disconnect velux on hass stop #26266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 15 commits into from
Sep 17, 2019
Merged

Disconnect velux on hass stop #26266

Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
326e3c0
velux KLF200 device did not disconnect properly when rebooting the ha…
gibman Aug 29, 2019
1f6fb5d
removed comment
gibman Aug 29, 2019
7f5993d
removed comment
gibman Aug 29, 2019
3e3255c
trigger bot
gibman Aug 29, 2019
ac2cd07
trigger bot
gibman Aug 29, 2019
84a866a
Merge branch 'master' of https://github.com/gibman/home-assistant
gibman Aug 29, 2019
7f4c50e
trigger bot
gibman Aug 29, 2019
15d59d4
logging casing fixed. code moved from init.
gibman Sep 4, 2019
8c24093
logger level debug
gibman Sep 5, 2019
ba02445
DOMAIN part of config passed to module.
gibman Sep 6, 2019
bc3e638
removed trailing whitespaces etc.
gibman Sep 13, 2019
1c20ede
black --fast changes
gibman Sep 13, 2019
57ce7d3
added missing docstring
gibman Sep 13, 2019
dbd0392
D400 First line should end with a period
gibman Sep 16, 2019
aa9cb16
black formatting
gibman Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions homeassistant/components/velux/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
"""Support for VELUX KLF 200 devices."""
import logging

import voluptuous as vol
from pyvlx import PyVLX
from pyvlx import PyVLXException

from homeassistant.helpers import discovery
import homeassistant.helpers.config_validation as cv
from homeassistant.const import CONF_HOST, CONF_PASSWORD
from homeassistant.const import (CONF_HOST, CONF_PASSWORD, EVENT_HOMEASSISTANT_STOP)

DOMAIN = "velux"
DATA_VELUX = "data_velux"
Expand All @@ -23,11 +24,10 @@


async def async_setup(hass, config):
"""Set up the velux component."""
from pyvlx import PyVLXException

"""Set up the velux component."""
try:
hass.data[DATA_VELUX] = VeluxModule(hass, config)
hass.data[DATA_VELUX] = VeluxModule(hass, config[DOMAIN])
hass.data[DATA_VELUX].setup()
await hass.data[DATA_VELUX].async_start()

except PyVLXException as ex:
Expand All @@ -44,15 +44,28 @@ async def async_setup(hass, config):
class VeluxModule:
"""Abstraction for velux component."""

def __init__(self, hass, config):
def __init__(self, hass, domain_config):
"""Initialize for velux component."""
from pyvlx import PyVLX
self.pyvlx = None
self._hass = hass
self._domain_config = domain_config

Comment thread
MartinHjelmare marked this conversation as resolved.
Outdated

host = config[DOMAIN].get(CONF_HOST)
password = config[DOMAIN].get(CONF_PASSWORD)
def setup(self):
async def on_hass_stop(event):
"""Close connection when hass stops."""
_LOGGER.debug("Velux interface terminated")
await self.pyvlx.disconnect()

self._hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, on_hass_stop)
host = self._domain_config.get(CONF_HOST)
password = self._domain_config.get(CONF_PASSWORD)
self.pyvlx = PyVLX(host=host, password=password)


async def async_start(self):
"""Start velux component."""
_LOGGER.debug("Velux interface started")
await self.pyvlx.load_scenes()
await self.pyvlx.load_nodes()