Skip to content

Fix torque degree char #26183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Sep 18, 2019
Merged

Fix torque degree char #26183

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cdacdf
Fix for \xC2\xB0 char instead of degree symbol
roblandry Aug 24, 2019
0baff7b
Remove comment
roblandry Aug 24, 2019
2c0c13a
Black
roblandry Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion homeassistant/components/torque/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,12 @@ def get(self, request):
names[pid] = data[key]
elif is_unit:
pid = convert_pid(is_unit.group(1))
units[pid] = data[key]

temp_unit = data[key]
if "\\xC2\\xB0" in temp_unit:
temp_unit = temp_unit.replace("\\xC2\\xB0", "°")
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible to solve this by applying the correct encoding at some point in the flow after receiving the request?

Copy link
Copy Markdown
Contributor Author

@roblandry roblandry Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I am not a proficient python coder, and this was the only way i was able to correct the units. The posted url is a query string with these characters. Seeing as how this was left effectively broken, I tinkered until I found a working solution. I'm all ears if you have a cleaner solution.

Copy link
Copy Markdown
Contributor

@tsvi tsvi Sep 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if the following would fix your issue:

units[pid] = data[key].decode("utf-8")


units[pid] = temp_unit
elif is_value:
pid = convert_pid(is_value.group(1))
if pid in self.sensors:
Expand Down