Skip to content

Add person to device_sun_light_trigger#25877

Merged
balloob merged 3 commits into
home-assistant:devfrom
kellerza:device_sun_person
Sep 6, 2019
Merged

Add person to device_sun_light_trigger#25877
balloob merged 3 commits into
home-assistant:devfrom
kellerza:device_sun_person

Conversation

@kellerza
Copy link
Copy Markdown
Member

@kellerza kellerza commented Aug 11, 2019

Description:

Allow person to be tracked by device_sun_ligt_trigger

Does this make sense? (requires some tests)

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10237

Example entry for configuration.yaml (if applicable):

person:

device_sun_light_trigger:
  light_group: group.living
  light_profile: relax
  device_group: group.devices

group:
  devices:
    entities:
      - person.johann

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@balloob balloob merged commit 5994f82 into home-assistant:dev Sep 6, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants