Skip to content

UniFi - Handle disabled devices #25625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kane610 merged 1 commit into from
Aug 1, 2019
Merged

UniFi - Handle disabled devices #25625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/unifi/device_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def unique_id(self) -> str:
@property
def available(self) -> bool:
"""Return if controller is available."""
return self.controller.available
return not self.device.disabled and self.controller.available

@property
def device_info(self):
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/unifi/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"config_flow": true,
"documentation": "https://www.home-assistant.io/components/unifi",
"requirements": [
"aiounifi==8"
"aiounifi==9"
],
"dependencies": [],
"codeowners": [
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ aiopvapi==1.6.14
aioswitcher==2019.4.26

# homeassistant.components.unifi
aiounifi==8
aiounifi==9

# homeassistant.components.wwlln
aiowwlln==1.0.0
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ aionotion==1.1.0
aioswitcher==2019.4.26

# homeassistant.components.unifi
aiounifi==8
aiounifi==9

# homeassistant.components.wwlln
aiowwlln==1.0.0
Expand Down
10 changes: 10 additions & 0 deletions tests/components/unifi/test_device_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,16 @@ async def test_tracked_devices(hass, mock_controller):
device_1 = hass.states.get("device_tracker.device_1")
assert device_1.state == "home"

device_1_copy = copy(DEVICE_1)
device_1_copy["disabled"] = True
mock_controller.mock_client_responses.append({})
mock_controller.mock_device_responses.append([device_1_copy])
await mock_controller.async_update()
await hass.async_block_till_done()

device_1 = hass.states.get("device_tracker.device_1")
assert device_1.state == "unavailable"
Comment thread
Kane610 marked this conversation as resolved.


async def test_restoring_client(hass, mock_controller):
"""Test the update_items function with some clients."""
Expand Down