Skip to content

Enable cert_expiry config entries #25624

Merged
MartinHjelmare merged 15 commits into
home-assistant:devfrom
cereal2nd:cert_expiry
Aug 28, 2019
Merged

Enable cert_expiry config entries #25624
MartinHjelmare merged 15 commits into
home-assistant:devfrom
cereal2nd:cert_expiry

Conversation

@cereal2nd
Copy link
Copy Markdown
Contributor

@cereal2nd cereal2nd commented Aug 1, 2019

Description:

This enables config entries for the cert_expiry component

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10241

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cereal2nd
Copy link
Copy Markdown
Contributor Author

are we still missing something in this PR?
it has been here for 25 days now and nothing happend with it

@MartinHjelmare
Copy link
Copy Markdown
Member

There's a long queue of open PRs and only a few reviewers. Bigger PRs are also harder to find time for. Config entry PRs are inherently quite big.

Comment thread homeassistant/components/cert_expiry/__init__.py Outdated
Comment thread homeassistant/components/cert_expiry/config_flow.py Outdated
Comment thread homeassistant/components/cert_expiry/config_flow.py Outdated
Comment thread homeassistant/components/cert_expiry/sensor.py Outdated
Comment thread homeassistant/components/cert_expiry/manifest.json Outdated
Comment thread homeassistant/components/cert_expiry/config_flow.py Outdated
Comment thread tests/components/cert_expiry/test_config_flow.py Outdated
Comment thread tests/components/cert_expiry/test_config_flow.py Outdated
Comment thread tests/components/cert_expiry/test_config_flow.py Outdated
Comment thread tests/components/cert_expiry/test_config_flow.py Outdated
Comment thread homeassistant/components/cert_expiry/config_flow.py Outdated
Comment thread homeassistant/components/cert_expiry/helper.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 33bd9c8 into home-assistant:dev Aug 28, 2019
@cereal2nd cereal2nd deleted the cert_expiry branch August 28, 2019 19:15
@lock lock Bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants