Skip to content

Add MQTT climate precision#25265

Merged
balloob merged 2 commits into
home-assistant:devfrom
PhilRW:mqtt-climate-precision
Jul 18, 2019
Merged

Add MQTT climate precision#25265
balloob merged 2 commits into
home-assistant:devfrom
PhilRW:mqtt-climate-precision

Conversation

@PhilRW
Copy link
Copy Markdown
Contributor

@PhilRW PhilRW commented Jul 18, 2019

Description:

Add precision to MQTT climate devices for when home-assistant/frontend#3109 gets fixed.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9896

Example entry for configuration.yaml (if applicable):

climate:
  - platform: mqtt
    name: Study
    modes:
      - "off"
      - "cool"
      - "fan_only"
    swing_modes:
      - "on"
      - "off"
    fan_modes:
      - "high"
      - "medium"
      - "low"
    power_command_topic: "study/ac/power/set"
    mode_command_topic: "study/ac/mode/set"
    temperature_command_topic: "study/ac/temperature/set"
    fan_mode_command_topic: "study/ac/fan/set"
    swing_mode_command_topic: "study/ac/swing/set"
    precision: 1.0

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@PhilRW PhilRW requested a review from a team as a code owner July 18, 2019 17:50
@ghost
Copy link
Copy Markdown

ghost commented Jul 18, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Comment thread homeassistant/components/mqtt/climate.py Outdated
@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 18, 2019

Referenced issue is not a bug. Precision is only used for when we're converting between C and F in the backend. target_temperature_step is the property that defines the step size for changing the target temperature.

@PhilRW PhilRW force-pushed the mqtt-climate-precision branch from 7662399 to 22c4068 Compare July 18, 2019 21:31
@balloob balloob merged commit 1c6d55e into home-assistant:dev Jul 18, 2019
@PhilRW PhilRW deleted the mqtt-climate-precision branch July 18, 2019 22:38
@lock lock Bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants