Add vendor support for vorwerk robots and fix zone retrieval#25200
Merged
balloob merged 8 commits intoJul 18, 2019
Merged
Conversation
2 tasks
MartinHjelmare
requested changes
Jul 17, 2019
Member
Author
|
Thank you for your review @MartinHjelmare :) |
MartinHjelmare
approved these changes
Jul 17, 2019
Member
Author
|
Forgot to mention but we can also close this feature request in the forum once we merge this :) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
As the
vendordefault remains asneatothis is not a breaking change for neato users.Description:
This PR has a few small changes:
Related issue (if applicable): fixes #21796
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9882
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: