Skip to content

Add support for recording history to Apache Kafka#25085

Merged
pvizeli merged 9 commits into
home-assistant:devfrom
bachya:kafka
Jul 12, 2019
Merged

Add support for recording history to Apache Kafka#25085
pvizeli merged 9 commits into
home-assistant:devfrom
bachya:kafka

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Jul 11, 2019

Description:

This PR adds support for recording history to an Apache Kafka topic.

Related issue (if applicable): home-assistant/home-assistant.io#9836

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

apache_kafka:
  ip_address: localhost
  port: 9092
  topic: home_assistant_1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread homeassistant/components/apache_kafka/manifest.json Outdated
@pvizeli pvizeli merged commit 69cc6af into home-assistant:dev Jul 12, 2019
@bachya bachya deleted the kafka branch July 12, 2019 13:16
@lock lock Bot locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants