Splunk component filter support#25071
Merged
MartinHjelmare merged 5 commits intoJul 12, 2019
Merged
Conversation
…unk component, and the code to enforce the filter.
…ly to more easily write a test case where I can mock the point where the post would occur and validate that filtering is working correctly. * Test cases created for full config check and to test the filtering
MartinHjelmare
requested changes
Jul 11, 2019
| timeout=10, verify=True) | ||
| self.mock_post.reset_mock() | ||
|
|
||
| def _setup_with_filter(self, mock_requests): |
Member
There was a problem hiding this comment.
mock_requests isn't used in this function. We don't need to pass it here. It's active in the test, that's enough.
Contributor
Author
There was a problem hiding this comment.
Thanks. Missed that. I originally started trying to model my setup after another used for this component. I eventually deviated and went a whole other way (taking out use of mock_requests). Updated.
Contributor
Author
|
Sweet. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adding "filter" support for the Splunk component. Filter implementation is modeled after the current HomeKit component filter support. This is the THIRD PR for this. First attempt was screwy in terms of commit information, and couldn't figure out how to resolve with prior PR, so started over. Second had a long pause while I found the time to figure out how to write the test cases. This time, everything should be ready to go with little delay (hopefully).
Pull request with documentation for home-assistant.io (if applicable): TBD; need to create; will update
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices: