Remove monitored conditions from syncthru configuration#25052
Merged
Conversation
2 tasks
10cec7e to
6952139
Compare
MartinHjelmare
approved these changes
Jul 10, 2019
Member
There was a problem hiding this comment.
Thanks!
Please write the breaking change paragraph so we can copy it directly to the release notes. It should mention what has changed and explain what the user needs to do to cope with the breaking change.
Eg:
The monitored_conditions configuration option has been removed. All available monitored conditions will be used by default. Users that have been using the monitored_conditions option need to remove it from the syncthru section in configuration.yaml.
You can add a link to the adr in the first sentence.
Contributor
Author
|
I have now simply copied your paragraph, including a link. Is it ok like that? |
MartinHjelmare
approved these changes
Jul 11, 2019
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Great!
Please rebase on latest dev branch to let the build pass.
6952139 to
049a89a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The monitored_conditions configuration option has been removed. All available monitored conditions will be used by default. Users that have been using the monitored_conditions option need to remove it from the syncthru section in configuration.yaml.
Description:
As noted in this comment on my last PR monitored conditions are to be successively removed from home-assistant. Thus, now it is forbidden to use them anymore.
Removes the option of specifying monitored conditions in the syncthru component.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9825
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.