Add support for World Wide Lightning Location Network#25001
Conversation
|
Sounds like this could better be a For each lightning strike within the configured radius a new geo_location entity is created. Optionally let the time frame be configured to set the clean up window when entities should be removed. If the user wants to count strikes a template sensor can be used. |
|
@MartinHjelmare Interesting! Let me ponder that. One issue I currently see: the EDIT: Another issue is that the |
|
The geo_location component is a general base component and doesn't rely on any specific library or metric system. |
|
Ahh, okay; I misread and assumed you meant GeoRSS. Let me dig into this a bit. |
|
@MartinHjelmare I've refocused this PR from sensors to geolocation; will appreciate your thoughts at your leisure. FYI, this is now waiting on #25046 (which allows geolocation platforms to use config entries). |
|
@MartinHjelmare In addition to addressing your latest feedback, I realized |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks great!
Unfortunately python 3.7 tests are flaky at the moment so I can't merge. We have to wait for an admin or until we fix the tests and can rebase.
Description:
This PR adds support for the World Wide Lightning Location Network (WWLLN) as a geolocation platform.
Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9802
Example entry for
configuration.yaml(if applicable):wwlln:Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: