Skip to content

Add support for Rainforest Eagle-200#24919

Merged
pvizeli merged 12 commits intohome-assistant:devfrom
gtdiehl:rainforest-eagle
Jul 18, 2019
Merged

Add support for Rainforest Eagle-200#24919
pvizeli merged 12 commits intohome-assistant:devfrom
gtdiehl:rainforest-eagle

Conversation

@gtdiehl
Copy link
Copy Markdown
Contributor

@gtdiehl gtdiehl commented Jul 3, 2019

Breaking Change:

None

Description:

Add integration for Rainforest Eagle-200 device

Related issue (if applicable): None

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9761

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
sensor:
  - platform: rainforest_eagle
    ip_address: <IP Address>
    cloud_id: <Cloud ID>
    install_code: <Install Code>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bbrendon
Copy link
Copy Markdown
Contributor

bbrendon commented Jul 3, 2019

I don't suppose anyone knows if this works for the z109 too?

@gtdiehl
Copy link
Copy Markdown
Contributor Author

gtdiehl commented Jul 3, 2019

I haven't tried it against an original Eagle (z109) but I dont think it would work since the Eagle and Eagle-200 (z114) API calls are different.

Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Copy link
Copy Markdown
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last issue and then is ready to merge 👍

Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Comment thread homeassistant/components/rainforest_eagle/sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pvizeli pvizeli merged commit 3fd138b into home-assistant:dev Jul 18, 2019
@lock lock Bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants