Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for remote dev container #24681

Merged
merged 2 commits into from
Jun 23, 2019
Merged

Add initial support for remote dev container #24681

merged 2 commits into from
Jun 23, 2019

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jun 21, 2019 •
edited
Loading

Description:

Add initial support for Remote Containers: https://code.visualstudio.com/docs/remote/containers

I know, it's not perfect but a good start

@pvizeli pvizeli requested a review from a team June 21, 2019 16:14
@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Jun 21, 2019
pvizeli
pvizeli commented Jun 21, 2019
View reviewed changes
.devcontainer/Dockerfile Outdated
# Install Python dependencies from requirements.txt if it exists
COPY requirements_test_all.txt /workspace/
RUN pip3 install -r requirements_test_all.txt \
&& pip install tox
Copy link
Member Author

@pvizeli pvizeli Jun 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make no sense to add tox because you can run command directly/native

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meu

@balloob balloob changed the title Add initial support for remote container Add initial support for remote dev container Jun 21, 2019
@michaelarnauts
Copy link
Contributor

I guess the Dev dockerfile exists for this, so does this replace that file?

@pvizeli
Copy link
Member Author

pvizeli commented Jun 23, 2019

Well, that would be removed with: home-assistant/architecture#243

@michaelarnauts
Copy link
Contributor

Okay! All in favor for cleaning things up, and using one image!

@balloob
Copy link
Member

balloob commented Jun 23, 2019

We should also update the developer docs

@balloob balloob merged commit a807572 into dev Jun 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the devcontainer branch June 23, 2019 19:18
@balloob
Copy link
Member

balloob commented Jun 23, 2019

Here are some things that should be addressed:

  • Do we want to ignore existing virtualenvs installed in the repo (bin, lib dirs)
  • Document how one gets started
  • Document how you can develop a lib for an integration in HA and install that dev version
  • Document how to run tests
  • Document how to debug (ptsvsd integration?)
  • enable flake8/pydocstyle in devcontainer settings?

@balloob balloob mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jelboy15 Jelboy15 Jelboy15 left review comments

Assignees
No one assigned
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pvizeli @michaelarnauts @balloob @Jelboy15 @homeassistant