Fix recorder defaults#24399
Merged
Merged
Conversation
homeassistant
added
core
has-tests
integration: recorder
small-pr
9 tasks
andrewsayre
reviewed
Jun 8, 2019
andrewsayre
approved these changes
Jun 8, 2019
balloob
force-pushed
the
recorder-defaults
branch
from
97eac06 to
19d22c3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
We used to have a bug that caused users that did not specify
recorder:in their configuration (probably most of you), to not have their database automatically purged. This will start happening now as per the default settings. This might take a while the first time as it hasn't done any clean up in a while.Description:
If the recorder integration was loaded as a dependency of another integration, the default config was not being applied. This is probably the case for 95% of our users.
This means that we never purged old DBs 🙈
Adding breaking change to clarify what is going on.
Related issue (if applicable): fixes #24386
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: