Remove deprecated Homematic IP AlarmControlPanel #24322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: homematicip_cloud
small-pr
|
Please expand the breaking change description to be from the user's point-of-view and document what they must do to accommodate the change. |
andrewsayre
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
Looks good. Can you confirm the docs don't need to be updated?
|
I updated the breaking change section. I hope this description fits better. |
|
I updated the documentation to mention the combined Alarm Control Panel. |
2 tasks
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
This PR removes the old implemenations of Alarm Control Panels (alarm_control_panel.EXTERNAL and alarm_control_panel.INTERNAL). Please use the new unified Alarm Control Panel (*hmip_alarm_control_panel ) that was introduced with HA 0.93.0.
Description:
Remove deprecated Alarm Control Panels.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9570
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: