Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handling for Netatmo climate #24311

Merged

Conversation

cgtobi
Copy link
Contributor

@cgtobi cgtobi commented Jun 5, 2019

Description:

Try to catch when the update of rooms failes.

Related issue (if applicable): fixes #23990

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cgtobi cgtobi changed the title Add exception handling Add exception handling for Netatmo climate Jun 5, 2019
@cgtobi cgtobi requested a review from Danielhiversen June 6, 2019 06:39
@Danielhiversen Danielhiversen merged commit 9ca5bdd into home-assistant:dev Jun 6, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
@cgtobi cgtobi deleted the netatmo_climate_exception_handling branch August 25, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netatmo thermostat not working in 93.1
3 participants