Centralizes Toon data, reducing API calls #23988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
|
2 tasks
pvizeli
reviewed
May 22, 2019
pvizeli
reviewed
May 22, 2019
|
Blocked by #23899 |
balloob
reviewed
May 23, 2019
balloob
approved these changes
May 23, 2019
frenck
changed the title
|
Since the blocking PR has been merged: |
|
Blocked by #25027 |
Fixes #21825 Signed-off-by: Franck Nijhof <[email protected]>
Signed-off-by: Franck Nijhof <[email protected]>
Signed-off-by: Franck Nijhof <[email protected]>
|
Rebased onto origin/dev, addressed review comment. |
frenck
changed the title
|
I have a followup PR ready that enhances this a bit more and improves the use of Climate 1.0. However, I did not want to mix it up into this PR. |
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Oct 12, 2019
* Centralizes Toon data, reducing API calls Fixes home-assistant#21825 Signed-off-by: Franck Nijhof <[email protected]> * Fixes bad copy past action in services.yaml Signed-off-by: Franck Nijhof <[email protected]> * Addresses review comments Signed-off-by: Franck Nijhof <[email protected]> * 👕 Fixes too many blank lines * Unsub dispatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Centralizes all Toon data, resulting in a heavy reduction of the API call's made.
The TTL cache mechanism used by the
toonapilibcan't handle our use case correctly.Related issue (if applicable): fixes #21825
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9488
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices:
Signed-off-by: Franck Nijhof [email protected]