Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add evohome water heater #23969

Closed
wants to merge 106 commits into from
Closed

WIP: Add evohome water heater #23969

wants to merge 106 commits into from

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented May 18, 2019

Breaking Change:

None

Description:

Adds a water_heater to the evohome integration.

Related issue (if applicable): None

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

  • uncahnged -

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works. (N?A)

@zxdavb
Copy link
Contributor Author

zxdavb commented May 18, 2019

@MartinHjelmare I'd be grateful if you had time for this one too.

homeassistant/components/evohome/climate.py Outdated Show resolved Hide resolved
homeassistant/components/evohome/water_heater.py Outdated Show resolved Hide resolved
homeassistant/components/evohome/water_heater.py Outdated Show resolved Hide resolved
homeassistant/components/evohome/water_heater.py Outdated Show resolved Hide resolved
homeassistant/components/evohome/water_heater.py Outdated Show resolved Hide resolved
homeassistant/components/evohome/water_heater.py Outdated Show resolved Hide resolved
@zxdavb
Copy link
Contributor Author

zxdavb commented Jun 7, 2019

@pvizeli OK, I rebased. This PR is not yet ready to merge to the climate-1.0 branch, but the original changes were almost exclusively limited to water_heater.py, with only refactoring of climate.py because @MartinHjelmare asked me to rename some attributes, etc.

You can see water_heater.py was just over 100 new lines, and this PR is now >800 lines changed with the migrating.

Can I just not get the water_heater merged (with some changes to __init__.py to support the next PR), then I'll do another PR for climate?

@zxdavb zxdavb changed the base branch from climate-1.0 to dev June 12, 2019 04:51
@zxdavb zxdavb changed the title Add evohome water heater WIP: Add evohome water heater Jun 12, 2019
@zxdavb zxdavb closed this Jun 12, 2019
@zxdavb zxdavb deleted the add_evohome_water_heater branch June 12, 2019 05:01
@zxdavb
Copy link
Contributor Author

zxdavb commented Jun 12, 2019

Stuck in rebase hell - will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants