Setup integration dependencies before loading it#23957
Merged
Merged
Conversation
awarecan
approved these changes
May 17, 2019
Contributor
awarecan
left a comment
There was a problem hiding this comment.
LGTM, can be merged after test passed
rohankapoorcom
approved these changes
May 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The PR is fixing the situation when you are using the
check_configscript with components using top-level imports (likehue- example here).The component was loaded before the dependencies were setup. The component cannot be loaded if an
importstatement from an (yet) unknown package was present.Related issue (if applicable): fixes #23488
Example entry for
configuration.yaml(if applicable):hue:$ hass -c . --script check_config Testing configuration at /Users/aerialls/Projects/ha-dependencies-bug/. Failed config General Errors: - Component not found: hue Successful config (partial)Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: