Skip to content

Fixes issue with multiple alerts#23945

Merged
pvizeli merged 3 commits into
home-assistant:devfrom
ludeeus:fix-multiple-alerts
May 18, 2019
Merged

Fixes issue with multiple alerts#23945
pvizeli merged 3 commits into
home-assistant:devfrom
ludeeus:fix-multiple-alerts

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 17, 2019

Description:

When the OS time and the configured TZ for HA differ, the alert component will send one notification every second.

This change forces it to use the defined TZ, and with that, it only sends notifications when they are expected.

Related issue (if applicable): fixes #21860

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9474

Example entry for configuration.yaml (if applicable):

homeassistant:
  time_zone: America/Los_Angeles

alert:
  garage_door:
    name: Garage is open
    done_message: Garage is closed
    entity_id: input_boolean.garage_door
    state: 'on'
    repeat: 5
    can_acknowledge: true
    skip_first: true
    notifiers:
      - pushbullet

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ludeeus ludeeus marked this pull request as ready for review May 17, 2019 14:36
@pvizeli pvizeli added this to the 0.93.2 milestone May 18, 2019
@pvizeli pvizeli merged commit 57bd418 into home-assistant:dev May 18, 2019
balloob pushed a commit that referenced this pull request May 23, 2019
* Fixes issue with multiple alerts

* Adds missing new line

* Remove whitespace
@balloob balloob mentioned this pull request May 23, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Fixes issue with multiple alerts

* Adds missing new line

* Remove whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alert (still) firing continuously if timezones differ

5 participants