Skip to content

Switch media player to SWITCH type#23914

Merged
balloob merged 1 commit into
home-assistant:devfrom
elupus:device_class_media_player_2
May 16, 2019
Merged

Switch media player to SWITCH type#23914
balloob merged 1 commit into
home-assistant:devfrom
elupus:device_class_media_player_2

Conversation

@elupus
Copy link
Copy Markdown
Contributor

@elupus elupus commented May 16, 2019

Description:

MEDIA device type is being rejected by google now.

Related issue (if applicable): fixes #23891

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

MEDIA device type is being rejected by google now.
@elupus elupus added this to the 0.93.1 milestone May 16, 2019
@balloob balloob merged commit c8cf06b into home-assistant:dev May 16, 2019
balloob pushed a commit that referenced this pull request May 17, 2019
MEDIA device type is being rejected by google now.
@balloob balloob mentioned this pull request May 17, 2019
@firstof9
Copy link
Copy Markdown
Contributor

I think this needed to be a action.devices.types.LIGHT in order to control the volume on media players. Unless removing that functionality was on purpose.

@elupus
Copy link
Copy Markdown
Contributor Author

elupus commented May 18, 2019

Volume works. It's using volume trait not the old brightness trait. You won't see it in home app though.

@firstof9
Copy link
Copy Markdown
Contributor

When I issued the command "Hey google, set the receiver to 90%" it told me that the device didn't support that function.

@pergolafabio
Copy link
Copy Markdown

Working fine here...
Make sure you are running 93.1

@pergolafabio
Copy link
Copy Markdown

Also do a "sync my devices"

@firstof9
Copy link
Copy Markdown
Contributor

@pergolafabio That seemed to fix it the sync, figured it would have done that after the 93.1 update on it's own.

@elupus
Copy link
Copy Markdown
Contributor Author

elupus commented May 18, 2019 via email

@firstof9
Copy link
Copy Markdown
Contributor

@elupus Yup already confirmed the re-sync fixed it up. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Assistant device sync broken in 0.93.0b4

5 participants