Skip to content

Fix problem with using Traccar events#23543

Merged
ludeeus merged 1 commit intohome-assistant:devfrom
klaasnicolaas:traccar-fix
Apr 30, 2019
Merged

Fix problem with using Traccar events#23543
ludeeus merged 1 commit intohome-assistant:devfrom
klaasnicolaas:traccar-fix

Conversation

@klaasnicolaas
Copy link
Copy Markdown
Member

@klaasnicolaas klaasnicolaas commented Apr 29, 2019

Description:

When using Traccar events, I received an error message with the current code. This fix makes it possible to use the event config variable again, I have already tested it locally.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@klaasnicolaas klaasnicolaas requested a review from ludeeus as a code owner April 29, 2019 17:16
@ghost ghost assigned ludeeus Apr 29, 2019
@ghost
Copy link
Copy Markdown

ghost commented Apr 29, 2019

Hey there @ludeeus, mind taking a look at this pull request as its been labeled with a integration (traccar) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@ludeeus ludeeus added this to the 0.92.2 milestone Apr 30, 2019
@ludeeus ludeeus merged commit 5d5f073 into home-assistant:dev Apr 30, 2019
balloob pushed a commit that referenced this pull request May 2, 2019
@balloob balloob mentioned this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants