Only include agent user ID in SYNC responses#23497
Merged
Merged
Conversation
homeassistant
added
cla-signed
core
integration: cloud
integration: google_assistant
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
pvizeli
approved these changes
Apr 28, 2019
balloob
added a commit
that referenced
this pull request
May 2, 2019
Merged
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Cloud would set
agentUserIdon every response, while it's only necessary for SYNC responses. This fixes the issue.Related issue (if applicable): #23412
Checklist:
tox. Your PR cannot be merged unless tests pass