Skip to content

Fix netatmo_public sensor to use netatmo authentication#23455

Merged
andrewsayre merged 1 commit into
home-assistant:devfrom
cgtobi:netatmo_public_refactor
Apr 27, 2019
Merged

Fix netatmo_public sensor to use netatmo authentication#23455
andrewsayre merged 1 commit into
home-assistant:devfrom
cgtobi:netatmo_public_refactor

Conversation

@cgtobi
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi commented Apr 26, 2019

Description:

netatmo_public was broken due to changes in #23429.

Related issue (if applicable): fixes #23474

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre merged commit 96fb311 into home-assistant:dev Apr 27, 2019
@SiliconAvatar
Copy link
Copy Markdown
Contributor

Any reason this isnt in the 0.92.2 milestones?
This fix should probably be pushed out in the 0.92.2 patch.

@andrewsayre andrewsayre added this to the 0.92.2 milestone Apr 28, 2019
@andrewsayre
Copy link
Copy Markdown
Member

@SiliconAvatar it's now tagged.

@balloob balloob mentioned this pull request May 2, 2019
@cgtobi cgtobi deleted the netatmo_public_refactor branch August 25, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Netatmo Public sensors not available.

5 participants