Skip to content

Fix daikin setup#23440

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
fredrike:fix-daikin-setup
Apr 26, 2019
Merged

Fix daikin setup#23440
MartinHjelmare merged 1 commit intohome-assistant:devfrom
fredrike:fix-daikin-setup

Conversation

@fredrike
Copy link
Copy Markdown
Contributor

@fredrike fredrike commented Apr 26, 2019

Description:

It could create a deadlock with using await self._hass.config_entries.async_forward_entry_setup, this uses a task to solve this issue.

Fix: "0.92 doesn't start frontend caused by daikin"

Related issue (if applicable): fixes #23368

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned fredrike Apr 26, 2019
@ghost
Copy link
Copy Markdown

ghost commented Apr 26, 2019

Hey there @rofrantz, mind taking a look at this pull request as its been labeled with a integration (daikin) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@fredrike
Copy link
Copy Markdown
Contributor Author

@MartinHjelmare

This should be part of 0.91.1.

@fredrike fredrike changed the title fix daikin-setup Fix daikin-setup Apr 26, 2019
@awarecan awarecan added this to the 0.92.1 milestone Apr 26, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@codecov

This comment has been minimized.

@MartinHjelmare MartinHjelmare changed the title Fix daikin-setup Fix daikin setup Apr 26, 2019
@MartinHjelmare MartinHjelmare merged commit 08c36e0 into home-assistant:dev Apr 26, 2019
pvizeli pushed a commit that referenced this pull request Apr 26, 2019
@pvizeli pvizeli mentioned this pull request Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.92 doesn't start frontend caused by daikin

5 participants