Sonos support "on" for alexa#23427
Closed
pvizeli wants to merge 2 commits into
Closed
Conversation
homeassistant
added
cla-signed
integration: sonos
small-pr
ghost
assigned
|
Hey there @amelchio, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
amelchio
reviewed
Apr 26, 2019
Contributor
amelchio
left a comment
amelchio
left a comment
There was a problem hiding this comment.
This is strictly speaking wrong. Since Sonos are always-on devices they do not support turn_on/turn_off.
The Sonos media_player platform currently has an implementation that maps on/off to play/stop (should probably be play/pause) but maybe there is a better place to do this if it is a general requirement for e.g. Alexa?
Contributor
|
I should have added, I think this approach is okay for a hotfix. It must have been broken by #22878. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Bring back the support for using Alexa for Sonos. Not sure if that is the correct way? @balloob ?