Fix supported features gates in media_player volume up/down services#23419
Merged
Fix supported features gates in media_player volume up/down services#23419
Conversation
homeassistant
added
cla-signed
core
has-tests
integration: media_player
small-pr
balloob
approved these changes
Apr 26, 2019
pvizeli
pushed a commit
that referenced
this pull request
Apr 26, 2019
…23419) * Correct media player feature gates * Fix failing test * Lint...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Extend the functionality introduced in #22878 to allow passing in a list or acceptable feature sets to check before invoking a service. Updates the gates for
volume_downandvolume_upto accept eitherSUPPORT_VOLUME_SETorSUPPORT_VOLUME_STEP. This is not a breaking change because it loosens the tolerance for these services.Related issue: fixes #23418
Checklist:
tox. Your PR cannot be merged unless tests pass