Conversation
| await entry.async_setup(hass, integration=integration) | ||
|
|
||
| hass.config.components.add(component.DOMAIN) # type: ignore | ||
| hass.config.components.add(domain) |
Member
There was a problem hiding this comment.
Do we use component.DOMAIN in other places, or does this mean we don't need to define DOMAIN anymore?
Member
Author
There was a problem hiding this comment.
Yeah, it's optional now. I think that it's still good to keep around and use it to as a key for hass.data etc, because it allows for people to easily copy an integration and change the DOMAIN value to make a copy.
pvizeli
approved these changes
Apr 26, 2019
pvizeli
pushed a commit
that referenced
this pull request
Apr 26, 2019
* Make setup more robust * Fix typing
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
While trying to research reported custom component failure (I couldn't repro), I did some other tweaks to make us more resistant to bad custom components: