Skip to content

deCONZ - support carbon monoxide sensors#23410

Merged
andrewsayre merged 1 commit intohome-assistant:devfrom
Kane610:deconz-support-carbonmonoxide-sensors
Apr 26, 2019
Merged

deCONZ - support carbon monoxide sensors#23410
andrewsayre merged 1 commit intohome-assistant:devfrom
Kane610:deconz-support-carbonmonoxide-sensors

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Apr 25, 2019

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned Kane610 Apr 25, 2019
@ghost
Copy link
Copy Markdown

ghost commented Apr 25, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@andrewsayre andrewsayre merged commit c229a31 into home-assistant:dev Apr 26, 2019
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Apr 26, 2019

Thanks @andrewsayre 🎉

@Kane610 Kane610 deleted the deconz-support-carbonmonoxide-sensors branch April 26, 2019 15:08
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants