Skip to content

Fix Homematic IP Cloud handling of sabotage info#23397

Merged
balloob merged 1 commit intohome-assistant:devfrom
SukramJ:HmIP-Sabotage-Fix
Apr 25, 2019
Merged

Fix Homematic IP Cloud handling of sabotage info#23397
balloob merged 1 commit intohome-assistant:devfrom
SukramJ:HmIP-Sabotage-Fix

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Apr 25, 2019 •
edited
Loading

Description:

This PR fixes handling of sabotage info.
This property is now only evaluated if property exists for the device.

Related issue (if applicable): fixes #23399

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Apr 25, 2019 •
edited
Loading

Hi @MartinHjelmare, @balloob,
this is a candidate for 0.92.1.
Thanks

@MartinHjelmare MartinHjelmare added this to the 0.92.1 milestone Apr 25, 2019
@balloob balloob merged commit cef7ce1 into home-assistant:dev Apr 25, 2019
@SukramJ SukramJ deleted the HmIP-Sabotage-Fix branch April 26, 2019 02:51
@pvizeli pvizeli removed this from the 0.92.1 milestone Apr 26, 2019
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Apr 26, 2019

conflict with 0.92 tree

@anrada73 anrada73 mentioned this pull request May 5, 2019
Closed
@balloob balloob mentioned this pull request May 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

No one assigned

Labels

cla-signed integration: homematicip_cloud small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Homematic IP SMO not working correctly.

5 participants

@SukramJ @pvizeli @MartinHjelmare @balloob @homeassistant