Remove support for deprecated Sonos configuration#23385
Merged
Conversation
70d92a6 to
3f646f3
Compare
balloob
approved these changes
Apr 25, 2019
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Configuring the Sonos integration as a
media_player:platform in configuration.yaml was deprecated in 0.72 and has now been removed.Description:
This cleans up the Sonos setup:
setup_platformsupportdiscovery_infosupport that is never used because we now just prompt to set up a config entrycv.ensure_list_csvto splithostsI did not want to update all the old tests that depended on the deprecated config so I started over with fixtures (which I don't know much about, so I kept it small for now).
Example entry for
configuration.yaml(if applicable):Checklist:
tox.