Skip to content

Remove support for deprecated Sonos configuration#23385

Merged
amelchio merged 1 commit into
home-assistant:devfrom
amelchio:sonos-obsolete-old-config
Apr 26, 2019
Merged

Remove support for deprecated Sonos configuration#23385
amelchio merged 1 commit into
home-assistant:devfrom
amelchio:sonos-obsolete-old-config

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

Breaking Change:

Configuring the Sonos integration as a media_player: platform in configuration.yaml was deprecated in 0.72 and has now been removed.

Description:

This cleans up the Sonos setup:

  • Remove setup_platform support
  • Remove discovery_info support that is never used because we now just prompt to set up a config entry
  • Move config schema to the component (so the config is actually validated)
  • Use cv.ensure_list_csv to split hosts

I did not want to update all the old tests that depended on the deprecated config so I started over with fixtures (which I don't know much about, so I kept it small for now).

Example entry for configuration.yaml (if applicable):

sonos:
  media_player:
    hosts:
      - 192.0.2.25
      - 192.0.2.26

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

@amelchio amelchio force-pushed the sonos-obsolete-old-config branch from 70d92a6 to 3f646f3 Compare April 25, 2019 21:35
@amelchio amelchio merged commit 5dbf58d into home-assistant:dev Apr 26, 2019
Comment thread homeassistant/components/sonos/__init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants