Avoid homekit controller calling async code in sync context#23235
Merged
awarecan merged 1 commit intohome-assistant:devfrom Apr 19, 2019
Merged
Avoid homekit controller calling async code in sync context#23235awarecan merged 1 commit intohome-assistant:devfrom
awarecan merged 1 commit intohome-assistant:devfrom
Conversation
homeassistant
added
integration: homekit_controller
small-pr
ghost
assigned
Member
|
Can be merged when build passes. |
MartinHjelmare
changed the title
MartinHjelmare
changed the title
Member
|
The previous PR this PR is fixing is not going into 0.92. |
Contributor
|
Shoot, cache issue. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
More post-merge feedback from @MartinHjelmare for #23191.
This avoids calling the async methods on the storage in a sync context. This will get simpler in 0.94 as config flow gets rid of sync variant and gets rid of sync add_entities.