Fix returned info for ZHA bindable devices API call#23216
Merged
Adminiuga merged 1 commit intohome-assistant:devfrom Apr 19, 2019
Merged
Fix returned info for ZHA bindable devices API call#23216Adminiuga merged 1 commit intohome-assistant:devfrom
Adminiuga merged 1 commit intohome-assistant:devfrom
Conversation
ghost
assigned
|
Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
Member
|
Should these things have tests? |
Contributor
Author
|
This entire area still needs tests. It’s on the list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR corrects an issue where we weren't returning the all of the device info for bindable devices.
Checklist:
tox. Your PR cannot be merged unless tests pass