Skip to content

set myself as codeowner of xmpp, removed me from notify/*#23207

Merged
robbiet480 merged 2 commits intohome-assistant:devfrom
flowolf:dev
Apr 18, 2019
Merged

set myself as codeowner of xmpp, removed me from notify/*#23207
robbiet480 merged 2 commits intohome-assistant:devfrom
flowolf:dev

Conversation

@flowolf
Copy link
Copy Markdown
Contributor

@flowolf flowolf commented Apr 18, 2019

fix CODEOWNERS as suggested by @robbiet480

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Apr 18, 2019
Copy link
Copy Markdown
Contributor

@robbiet480 robbiet480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make these changes in the integration manifest files as well since CODEOWNERS is automatically generated from the manifest files.

Also, did you not want to add yourself to yesssms?

@flowolf flowolf requested a review from fabaff as a code owner April 18, 2019 19:12
@flowolf
Copy link
Copy Markdown
Contributor Author

flowolf commented Apr 18, 2019

changed the manifests, and I am already codeowner of yessssms; so that's fine.

@ghost
Copy link
Copy Markdown

ghost commented Apr 18, 2019

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (xmpp) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@robbiet480 robbiet480 merged commit daf2f30 into home-assistant:dev Apr 18, 2019
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants