Add services.yaml validator#23205
Merged
Merged
Conversation
| @@ -0,0 +1,104 @@ | |||
| """Validate dependencies.""" | |||
| data = load_yaml(str(integration.path / 'services.yaml')) | ||
| except FileNotFoundError: | ||
| print( | ||
| "Warning: {} registeres services but has no services.yaml".format( |
|
|
||
| validate_services(integration) | ||
|
|
||
| # check that all referenced dependencies exist |
Member
Author
There was a problem hiding this comment.
Oh oh. Too fast copy paste before I had to leave. Will fix.
balloob
added a commit
that referenced
this pull request
Apr 20, 2019
* Add services.yaml validator * Fix path
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Add services.yaml validator * Fix path
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Add services.yaml validator * Fix path
fredrikbaberg
pushed a commit
to fredrikbaberg/home-assistant
that referenced
this pull request
May 6, 2019
* Add services.yaml validator * Fix path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add validator for services.yaml.
Currently only a warning to not have a services.yaml while registering it, will await this wave of services.yaml PRs, then I will add stub files for it all.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirementsin the manifest (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: